Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing request.clone()? #9

Closed
jeffposnick opened this issue Nov 14, 2014 · 1 comment
Closed

Missing request.clone()? #9

jeffposnick opened this issue Nov 14, 2014 · 1 comment

Comments

@jeffposnick
Copy link

It looks like there are a couple of places in where the same event.request object is used in both a fetch() and a cache.put() (https://github.com/jakearchibald/trained-to-thrill/blob/master/www/static/js-unmin/sw/index.js#L65 and https://github.com/jakearchibald/trained-to-thrill/blob/master/www/static/js-unmin/sw/index.js#L107).

@jakearchibald mentioned elsewhere that both fetch() and cache.put() consume a request, so shouldn't the request that's passed to fetch() beclone()d first?

@jakearchibald
Copy link
Owner

Yes, good catch. I need to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants