-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of multiple signals across dual carriageway streets #6
Comments
Hey, I’ll take this up |
Hey Jake, I was working on this yesterday and needed some clarity. From what I have read on the internet, there are two types of dual carriageway crossings -
The first actually just includes two nodes or two pedestrian lights and our app can handle. But for the second we can ask the user if they were able to cross in one iteration and the timings. And this can be shown as one marker with the additional metadata. This requires an additional field in the db which indicates if two iteration were required or one and the timing for each - further another field in the form ? "Ideally it would be able to identify two traffic lights on the same OpenStreetMap pedestrian way which would indicate a dual carriageway crossing. "
|
Hey Ayaan, Thanks for picking this up! It is indeed a tricky one.
Yep I agree.
Yep I partly agree, I think this would be a flexible way of capturing this information which might not easily fit into a more rigid schema. I don't think we should request a timing for each in the same form if more than one cycle is required to cross - I would prefer we direct the user (or provide a link) to contribute a measuremnet for the other node nearby. (or if a node isn't present, using the location field). The bit where this gets tricky I think is that a sidewalk or crossing way (path) across a dual-carrigeway road on OpenStreetMap will have two nodes, one for each direction of the road, but not necessarily be a two stage crossing. By this comment
I was initially thinking perhaps we should add support for specifying a crossing way (path) rather than a single point. Not only would this be trickier architecturally, and I'm not sure if it would be desirable either. If we:
then some users might select a point, some a way, and the data will be very messy. I think I would prefer we only capture against nodes (as we do currently) and a possible post-processing step (whether just when doing analysis or even on the intersection stats page, or even to filter which points are shown as candidates to contribute to). I image this as as something like:
for this issue, I would recommend just biting off the "add a radio button whether it's a two stage crossing" part! |
okay I think I got it. I will begin by adding a radio button to the form to indicate if its a two stage crossing or not. The next stop would be to add that to the measurements in the backend, which would require a new boolean field in the schema and db. The already existing measurements will have the value 'False' for this. How would you want to proceed with schema changes and access ?
As you recommended - this is the extent of this issue for now ------- but to just understand for the future If the user submits a form and marks the radio as true for a two step crossing, we want to recommend another node to contribute to (this other node should be connected to the previous node by a 'crossing' or 'sidewalk'). This node is supposed to represent the second stage. I am unsure about when we make this recommendation ? - on the intersection stats page ?
The objective of this piece of pseudo-code would be to group observations when the crossing was not a 2 step but since there are 2 nodes, 1 for each side of the crossing - measurements for the same crossing might have been associated with different nodes. |
Yep sounds good!
I would recommend an optional string field, as this lets us add further values in future. We might start with
You can likely start from copy and pasting the form component and You'll likely hit issues setting up your own DB for the first time as nobody has done that before - please let me know and I can help out and improve the documentation! For future state
Yep this sounds great! If there is only one other That algorithm seems right! I've created #26 to track that issue. I've also created #25 for possible grouping improvements. |
Currently this tool only takes measurements for nodes, that is a single traffic light.
Ideally it would be able to identify two traffic lights on the same OpenStreetMap pedestrian way which would indicate a dual carriageway crossing. Additional metadata could be collected to record whether the pedestrian can cross in one green phase, or is required to wait an entire cycle and use 2 green phases.
For example: https://www.youtube.com/watch?v=JBZkpmW91PY
The text was updated successfully, but these errors were encountered: