Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for musl #93

Closed
8Mobius8 opened this issue Dec 13, 2022 · 3 comments · Fixed by #95
Closed

Support for musl #93

8Mobius8 opened this issue Dec 13, 2022 · 3 comments · Fixed by #95

Comments

@8Mobius8
Copy link
Contributor

8Mobius8 commented Dec 13, 2022

Add support for musl linked executable for distributions that use it (ie. Alpine). I would think this would be done by adding another asset on release that would be named
mask-vX.XX.X-x86_64-unknown-linux-musl.zip or something like it.

I have limited knowledge of rust, but seems like this could be achieved by adding another release job in .github/workflows/release.yml that could make use of an Alpine to build and target. I believe cargo needs use the target x86_64-unknown-linux-musl.

@8Mobius8
Copy link
Contributor Author

@jacobdeichert If you don't mind I would like to attempt the suggestion above.

I believe I should be able to test this out on a fork of this repo without affecting this one.

I will say this will be my first foray into github actions, so any advice would be welcome.

@jacobdeichert
Copy link
Owner

jacobdeichert commented Dec 16, 2022

@8Mobius8 that would be great!

Yes, modifying release.yml is all you need to do I think.

I'd copy/paste the release-linux block, name the new one release-linux-musl and then figure out how to tell cargo to target musl. My memory is a bit fuzzy on compiling for musl, but I think you can probably still use runs-on: ubuntu-latest and it should let you cross-compile to musl. Or, GitHub might support alpine runners, so up to you if that's easier to get cargo to target musl with.

@jacobdeichert
Copy link
Owner

@8Mobius8 just a heads up that I released v0.11.3

You can find the musl binary attached here:
https://github.com/jacobdeichert/mask/releases/tag/v0.11.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants