Move the mutation API out to separate builder objects. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's a rough proposal for how it could look to move the mutation side of the macro API to objects that are passed separately to the macro. This means there is no longer a need to maintain separate pairs of Foo and TargetFoo classes. I don't think it's a huge win in this PR, but as these APIs fill out with more members, I think the separation would become more valuable.
jakemac53
reviewed
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(You don't have to land this. Just sending a PR to get your attention. :) )
Here's a rough proposal for how it could look to move the mutation side
of the macro API to objects that are passed separately to the macro.
This means there is no longer a need to maintain separate pairs of Foo
and TargetFoo classes.
I don't think it's a huge win in this PR, but as these APIs fill out
with more members, I think the separation would become more valuable.