Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If cellHeight isn't set, the row height doesn't fallback to tableview.rowHeight in iOS 8 #14

Closed
duemunk opened this issue Aug 28, 2014 · 1 comment

Comments

@duemunk
Copy link
Contributor

duemunk commented Aug 28, 2014

Something like this fixes it, but I don't if it is the best way to handle the change made to UITableView in iOS 8

- (CGFloat) tableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPath *)indexPath {
    JMStaticContentTableViewSection *sectionContent = [self.staticContentSections objectAtIndex:indexPath.section];
    JMStaticContentTableViewCell *cellContent = [sectionContent.staticContentCells objectAtIndex:indexPath.row];
    if (cellContent.cellHeight < 0) { // Fix
        return tableView.rowHeight;
    }
    return cellContent.cellHeight;
}
@duemunk
Copy link
Contributor Author

duemunk commented Sep 19, 2014

Fixed in 46b5321

@duemunk duemunk closed this as completed Sep 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant