-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: adding 1px margin on all images to support browser zoom #15
Comments
If you are using the :horizontal or :vertical layout options, then there is also an (optional) :padding option you can use. Unfortunately its not supported when using the :packed layout option. I'll look into adding that in a future release. Thanks |
when I using padding, all image size are bigger, I need a margin.. |
Oops, sorry, my mistake. You're right, you need a margin option, not padding - to give the image more room in the spritesheet, but not in the x,y,w,h coords generated for the css. I'll try to add that in the next release |
Yep, that's exactly as @halida said. But I think you've already got that :) |
FYI: I've merged in @halida's pull request (Thanks!) into the master branch to add the new :margin option to the :horizontal and :vertical layout. I'll see if I can get some time this weekend to also support padding/margin in the :packed layout and then see about releasing a minor update to the gem itself. |
Hi Jake, |
Ok. It's done (on master branch). You can now specify I probably won't publish a new gem version for a little while, I'll try to accumulate a few more fixes before publishing, if that's a problem let me know - I can be persuaded to change my mind! |
It works great, thanks ! |
Does your comment mean that you won't push this change to rubygem ? I think it's really a great improvement since it prevents zooming from having a very bad effect :( |
No problem, I'll try to go through the last open issues and push a new version... maybe at the weekend ? |
take your time, this weekend or the next are both good options ! Thx a lot |
FYI: I've pushed a new sprite-factory gem (v1.5.0) with this change (and a couple others). You can read about it on codeincomplete.com |
this is huge, you made my day =) |
When browsers zoom, sometimes a line of the previous image appears on top of the wanted image. I suggest adding a 1px margin around all images to prevent this ugly effect from happening.
Y.
The text was updated successfully, but these errors were encountered: