Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest jar scripts doesn't update server #4

Closed
Jakesta13 opened this issue Nov 15, 2018 · 5 comments
Closed

Latest jar scripts doesn't update server #4

Jakesta13 opened this issue Nov 15, 2018 · 5 comments
Assignees

Comments

@Jakesta13
Copy link
Owner

The jar files are downloaded correctly but when uploading, ncftp doesn't replace the jar file.
The jar file must be deleted prior to uploading ...

@Jakesta13 Jakesta13 self-assigned this Nov 15, 2018
@Jakesta13
Copy link
Owner Author

Jakesta13 commented Nov 16, 2018

Possibly fixed, will close once confirmed -- this will be tested when mojang releases another version.
See lftp in related commit

@Jakesta13
Copy link
Owner Author

Not entirely fixed -- only works when manually ran.. running through cron-job doesn't seem to work, it only deletes the jar to replace, thus temporarily disabling the server. Debugging is being conducted.

@Jakesta13
Copy link
Owner Author

Jakesta13 commented Nov 25, 2018

Should be fixed in latest push, I forgot to add BASE_DIR variable to the download of the jar files, so it would work manually but not when automatically ran via cronjob.

see latest release for changes.

Will close once verified.

@Jakesta13
Copy link
Owner Author

Successfully updated to 19w02a automatically, though will wait until next snapshot for complete verification that there isn't another problem with the script before closing this issue.

@Jakesta13
Copy link
Owner Author

Fixed.
Download file is checked if it contains text or not. If the file appears blank then the script will abort.

Also, the jar file that this script will replace is deleted before being replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant