Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for code blocks #35

Merged
merged 2 commits into from Jan 11, 2022
Merged

Conversation

nxsy
Copy link
Contributor

@nxsy nxsy commented Jan 9, 2022

Fairly straightforward copy of what the other code is doing, and works when used on pages with code examples.

text is a list of rich text objects, and language is an effectively unbounded list of potential languages, so string seemed preferable to an enum.

Copy link
Owner

@jakeswenson jakeswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for the contribution!

src/models.rs Show resolved Hide resolved
@jakeswenson jakeswenson enabled auto-merge (squash) January 11, 2022 05:51
src/models.rs Outdated Show resolved Hide resolved
@jakeswenson jakeswenson merged commit dcf4654 into jakeswenson:main Jan 11, 2022
@nxsy
Copy link
Contributor Author

nxsy commented Jan 14, 2022

Apologies for the extra work I left you by being careless, and thanks for doing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants