Get Block Children #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeswenson
requested changes
May 16, 2021
src/models.rs
Outdated
| #[derive(Serialize, Deserialize, Debug, Eq, PartialEq, Clone)] | ||
| pub struct Block { | ||
| id: BlockId, | ||
| r#type: BlockType, |
There was a problem hiding this comment.
Neat, but instead what about
Suggested change
| r#type: BlockType, | |
| #[serde(rename = "type")] | |
| block_type: BlockType, |
There was a problem hiding this comment.
Should block actually be an enum?
pub enum Block {
Paragraph {
#[serde(flatten)]
common: BlockCommon
}
...There was a problem hiding this comment.
Yeah it needs to be. ill refactor it
bspradling
force-pushed
the
feature/block-children
branch
from
aefe435
to
ddeced3
Compare
|
Closing in favor of #9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generic implementation of retrieving block information. I have yet to enumerate different fields for specific Block types.
Fixed some visibility issues for people using this client externally.
Fixed an casing issue when deserializing Url types