Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute links seem to be broken for "file:" on Windows #52

Closed
Euthoniel opened this issue Jun 13, 2022 · 7 comments
Closed

Absolute links seem to be broken for "file:" on Windows #52

Euthoniel opened this issue Jun 13, 2022 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@Euthoniel
Copy link

Euthoniel commented Jun 13, 2022

On Windows. Relative links work with the file prefix without issue, and markdown links using absolute path also work without error.

If I use "file:C:\Users\user\file.py" as my path, Windows tries to open the file with the default program, but starts at the location of the file I'm in. For example, if the above link was in C:\Project\Start.md, Windows would try to open the file at "C:\Project\C:\Users\user\file.py".

If I start the path with / instead of C:, the file opens correctly with the default program, but Neovim gives the below error.

Screenshot 2022-06-13 024829

@jakewvincent jakewvincent changed the title Absolute links seem to be broken for "file:" Absolute links seem to be broken for "file:" on Windows Jun 13, 2022
@jakewvincent jakewvincent self-assigned this Jun 13, 2022
@jakewvincent jakewvincent added the bug Something isn't working label Jun 13, 2022
@jakewvincent
Copy link
Owner

jakewvincent commented Jun 13, 2022

Thanks for the bug report! Can you pull the latest update and try this again? I think this was just due to a small typo in one of the regexes that helps identify absolute paths in Windows.

@Euthoniel
Copy link
Author

Euthoniel commented Jun 13, 2022

It works now with file:C:, but Neovim still gives the same error from the image in the first post, despite opening files correctly.

@jakewvincent
Copy link
Owner

This should be fixed now--can you check and report back? Thanks.

@Euthoniel
Copy link
Author

I get a slightly different error now, see attached. The file still opens correctly.
Screenshot 2022-06-13 153550

@jakewvincent
Copy link
Owner

Ok, I figured out where this was ultimately coming from, I think. Can you pull again and let me know if there are any errors?

@Euthoniel
Copy link
Author

Yes, it works without errors. Thanks for fixing it, especially so quickly.

@jakewvincent
Copy link
Owner

Great! Thanks for testing it repeatedly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants