Fix some warnings after migration #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 85.76% 85.78% +0.01%
==========================================
Files 12 12
Lines 1075 1076 +1
Branches 286 286
==========================================
+ Hits 922 923 +1
Misses 94 94
Partials 59 59 ☔ View full report in Codecov by Sentry. |
JakobGM
approved these changes
Mar 3, 2024
…sort sometimes on py39
thomasaarholt
force-pushed
the
thomasaarholt/fix-warnings
branch
from
40de7e2
to
03bff6b
Compare
thomasaarholt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm fixing some of the warnings introduced with the pydantic PR. Mainly adding docstrings where we had duplicates to copy from elsewhere, but also some minor typing things.