Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search not working so well #25

Closed
hinrik opened this issue Jan 1, 2022 · 5 comments
Closed

Search not working so well #25

hinrik opened this issue Jan 1, 2022 · 5 comments

Comments

@hinrik
Copy link

hinrik commented Jan 1, 2022

The first mod I tried searching for was https://www.curseforge.com/minecraft/mc-mods/playerex, however pacmc search playerex gives no results. Other search queries (like pacmc search minihud) do work, though.

@jakobkmar
Copy link
Owner

jakobkmar commented Jan 1, 2022

Hey, thanks for reportings this!

This mod is marked as Forge only on curseforge (by the author), and the current release version of pacmc filters these mods out.

In the future, pacmc will support Forge mods as well - but this Mods seems to be a Fabric mod which has incorrect metadata on Curseforge.
For a fix you can probably just ask the mod author to set the mod to be compatible with Fabric, as all other Fabric mods do it.

@hinrik
Copy link
Author

hinrik commented Jan 1, 2022

Interesting. I thought the author had indicated in some way that the mod is Fabric-compatible due to seeing this (when hovering over the +2):

fabric

But maybe they didn't do it in the proper way? Is there still a way for the search to pick up the information shown in the pop-up there, as a workaround?

@jakobkmar
Copy link
Owner

With the upcoming rewrite there is, but not at the moment.

And yeah it has not been done properly:
grafik

@jakobkmar
Copy link
Owner

The author can fix this very easily, maybe just wait for CleverNucleus/playerex#42 to get resolved.

@jakobkmar
Copy link
Owner

Has been fixed on both the old and the new Curseforge API implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants