Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does AD have a separate database? #489

Closed
willdean opened this issue Feb 27, 2016 · 3 comments
Closed

Why does AD have a separate database? #489

willdean opened this issue Feb 27, 2016 · 3 comments

Comments

@willdean
Copy link
Collaborator

I have been playing here (not with any specific intention of merging it) with getting rid of much of the AD-specific code, and just importing the AD users/teams into the EF database.

When I looked back at the history of the AD code, it appears from looking at 082d357 that this is actually what happened before the recent AD code arrived - there was a routine called WindowsIdentityImporter.cs which loaded the EF database with AD data.

Does anyone ( @jakubgarfield, @Ollienator, @RedX2501 ?) remember what the motivation for the separate database was, and why the import into the EF database was dropped?

@RedX2501
Copy link
Collaborator

Im afraid that happened before I joined the project.

But the current database format does not support sub groups, which the current ad provider does.

@willdean
Copy link
Collaborator Author

Ah right, I'll see if I can work out how subgroups work / what they are. The AD store is just a list of xxxModel objects so it hopefully isn't too far from what the EF store can do.

@RedX2501
Copy link
Collaborator

We could make AD derived from some base and only override the group functions. Or teach Bonobo about subgroups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants