Support PHP 8 #102
Support PHP 8 #102
Conversation
composer.json
Outdated
| "psr/log": "~1.0", | ||
| "react/event-loop": "^1.0 || ^0.5 || ^0.4", | ||
| "react/promise": "~2.2" | ||
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "~6.5" | ||
| "phpunit/phpunit": "^6.5 || ^7.5 || ^8.5 || ^9.3" |
There was a problem hiding this comment.
| "phpunit/phpunit": "^6.5 || ^7.5 || ^8.5 || ^9.3" | |
| "phpunit/phpunit": "^8.5 || ^9.3" |
@edudobay I think only these two make sense for "php": "^7.1 || ^8.0",: https://phpunit.de/supported-versions.html (or in other words, if this is to support PHP 8)
There was a problem hiding this comment.
@standa If PHP 7.1 is still to be supported, I think we need PHPUnit 7 too; Composer won't let us install PHPUnit 8 with PHP 7.1.
There was a problem hiding this comment.
I've dropped PHPUnit 6 and pushed a new commit to fix PHP 8 build. What do you think @standa?
|
Trying to fix these SSL issues here! It's hard to know what exactly went wrong, so I'm working on making local SSL testing easier as well — I had a hard time getting the SSL tests to run locally. |
|
@edudobay I tested this PR on our production code with php 8.0 today and it works like a charm! |
|
Nice to hear that, @standa! I just have to solve this SSL issue in the CI builds — I'll try to reproduce the CI environment on the next few days to see how I can fix this. |
edudobay
force-pushed
the
php8
branch
2 times, most recently
from
d977abd
to
afcaed2
Compare
- Fix method signatures — required parameters after optional arguments are deprecated in PHP 8. - Upgrade PHPUnit, adding void return type to setUp methods; this makes the syntax incompatible with PHP 7.0. - Drop PHP 7.0 and PHPUnit 6 support - PHPUnit 6 support ended on 2019-02-01 and PHP 7.0 end-of-life was almost at the same time. It becomes harder to support PHP 7.0 syntax at the same time as PHP 8.0. - rabbitmq-server package is now needed for Travis CI, starting with Ubuntu Xenial. PHP 8.0 is not available for Ubuntu Trusty in Travis CI. https://docs.travis-ci.com/user/database-setup/#rabbitmq - Fix RabbitMQ config files and permissions for SSL tests in CI (behavior seems to have changed across Ubuntu versions).
|
@WyriHaximus Yes, now this is ready :) And in fact there's a breaking change, so it also seems to me that it would be better suited for the 0.5.0 release. |
|
Ok just release |
Fixes the issues raised in #101.
There's one issue about dropping PHP 7.0 support:
voidreturn type to PHPUnitsetUpmethods: this makes the syntax incompatible with PHP 7.0