New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for SSL #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for taking the time to craft this extensive PR, and it looks great, there is only one change I'd would prefer: change ssl
to tls
where possible.
Personally, I have no objection regarding parameter name change, but this code will not look so neat:
If you are OK with that - I'll make this change. Also, should |
See #89 ;) |
Synced branch jakubkulhan/bunny:master |
Will have a look at it tomorrow 👍 . |
Yeah this suddenly makes sense looking at #89 🤐 ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comparing this with #89 made this one look less confusing regarding naming. Still would prefer TLS but this is easier to maintain 👍
Added usage of
stream_context_set_option
for setting SSL options.Added tests with certificate generation and ssl-enabled configuration for RabbitMQ.
Added some configuration examples for common use cases see
examples/ssl
directory.Mentioned SSL support in main
README.md
.Some notes:
prior 3.7.0
andsysctl
.Could not connect to...
message.Resolves #77