Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging annotations ? #6

Open
eddycharly opened this issue Jun 7, 2019 · 4 comments
Open

Merging annotations ? #6

eddycharly opened this issue Jun 7, 2019 · 4 comments

Comments

@eddycharly
Copy link

eddycharly commented Jun 7, 2019

Is this possible to merge annotations from several ingresses into the generated one ?

I mean i have some redirection rules in the original annotations that are not merged into the generated annotation, is there a way to get them merged somehow ?

@jakubkulhan
Copy link
Owner

Hi, no annotations don't get merged. However, you can specify annotations for the resulting ingress in the configmap - https://github.com/jakubkulhan/ingress-merge#configuration-keys

@Mr-Howard-Roark
Copy link

You can also specify annotations on your services, which take precedence over ingress annotations. I have found this to work well with the merge ingress controller. You can have a core set of annotations in the configmap that all ingresses share and then customize each service with whatever annotations are necessary.

@eddycharly
Copy link
Author

Thanks, i will look at service annotations on Monday.
I need to add action annotations to perform custom redirects. Not sure if I can add them on the service directly.

@low-on-mana
Copy link

I have a requirement for this case too.
Want to keep loadbalancer annotations in shared configmap
And keep targetgroup annotations ( like healthcheck etc ) in ingress object.

How do I achieve this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants