Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precision should be configurable #287

Closed
zzolo opened this issue Jun 5, 2014 · 8 comments
Closed

Precision should be configurable #287

zzolo opened this issue Jun 5, 2014 · 8 comments
Milestone

Comments

@zzolo
Copy link

zzolo commented Jun 5, 2014

#163

Rounding off decimals blankly is really bad and has caused me hours of headache. It would be super awesome if this was an option.

Thanks for the great module.

@GoalSmashers
Copy link
Contributor

Is it the same as #286?

@zzolo
Copy link
Author

zzolo commented Jun 5, 2014

Yeah, I believe so. Sorry about that. It applies more than just Bootstrap. Overall, its a fine default, but it should be configurable.

@GoalSmashers
Copy link
Contributor

Something like --skip-rounding?

@zzolo
Copy link
Author

zzolo commented Jun 5, 2014

That or --precision=10 which allows for other rounding which is indeed a good minifying step.

@GoalSmashers
Copy link
Contributor

May work even better. By the way does that line-height rounding to 5th decimal place really break the styling?

@zzolo
Copy link
Author

zzolo commented Jun 5, 2014

I have seen other people talk about Bootstrap and Sass's precision stuff like the other issue.

My specific issue is that I am using SVG and scaling a lot, so that my stroke widths are something like 0.0005px.

@GoalSmashers
Copy link
Contributor

@zzolo Will be fixed with 70c7aa1 in 2.2 which is coming in the next few days.

@zzolo
Copy link
Author

zzolo commented Jun 6, 2014

You are awesome!!!!!

(now to just get the changes pushed up to the contrib-grunt-cssmin module)

@zzolo zzolo closed this as completed Jun 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants