Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tim Peterson Benchmark comparing compression size of Clean-CSS and YUI compressor #71

Merged
merged 3 commits into from Feb 21, 2013

Conversation

tim-peterson
Copy link
Contributor

Tim Peterson Benchmark comparing compression size of Clean-CSS and YUI compressor

@XhmikosR
Copy link
Contributor

Your clean-CSS file doesn't seem minimized, is it?

@tim-peterson
Copy link
Contributor Author

You're right, it didn't minimize it. Though b/c it did shrink it somewhat it seemed that Clean-CSS did something. Not sure what was going on so that's when/why I started this issue...

@GoalSmashers
Copy link
Contributor

@tim-peterson Hmm, that's very interesting. I'll merge your PR and then investigate what's going on. It seems like a bug, however GoalSmashers.com also has such big CSS files and minimization works fine there.

Thanks for your effort!

GoalSmashers pushed a commit that referenced this pull request Feb 21, 2013
Tim Peterson Benchmark comparing compression size of Clean-CSS and YUI compressor
@GoalSmashers GoalSmashers merged commit 574e42f into clean-css:master Feb 21, 2013
@GoalSmashers
Copy link
Contributor

@tim-peterson - I ran the minimization of TP-demo locally and it minimizes correctly (size is ~246kB).

Could you please share what environment (Unix, Windows), node.js version, and clean-css version (cleancss -v) you use? It could be a deadly combination of those 3.

@XhmikosR
Copy link
Contributor

@GoalSmashers: Don't get me wrong, but this PR serves no purpose and it's useless for everyone else. It's just garbage files added in the repository,

@GoalSmashers
Copy link
Contributor

Please treat it as work in progress - we have a file from Tim which will serve as a basis for benchmarks.

Don't worry - at the end we will clean up the repository.

On 21 Feb 2013, at 10:39, XhmikosR notifications@github.com wrote:

@GoalSmashers: Don't get me wrong, but this PR serves no purpose and it's useless for everyone else. It's just garbage files added in the repository,


Reply to this email directly or view it on GitHub.

@tim-peterson
Copy link
Contributor Author

@GoalSmashers

Perhaps my environment is the problem. Should the node and cleancss versions match up?

Tims-MacBook-Pro:clean-css TimPeterson$ bin/cleancss -v
0.4.2
Tims-MacBook-Pro:clean-css TimPeterson$ node -v
v0.4.12

MacOSX 10.7.5

I admit I really know nothing about using Node. I'm pretty sure I installed Node awhile back to play with something else. I didn't install it to run Cleancss. All I did in using Cleancss was to download it onto my computer and use it as is. That now seems likely not sufficient and I apologize for wasting your time if that's the case.

The only thing I might have in my defense is that other beginner Node programmers would seem to likely to do the same thing (no errors = success, until its not) and so improving the README on the installation part might be a good idea.

@GoalSmashers
Copy link
Contributor

They have nothing to do with each other - node.js is at 0.8.x and cleancss at 0.10.1 now and lots have changed since our 0.4.x branch.

Could you please update node first and then cleancss with 'npm update -g clean-css' and give it another try?

Let me know if you need any assistance!

On 21 Feb 2013, at 15:10, tim peterson notifications@github.com wrote:

@GoalSmashers

Perhaps my environment is the problem. Should the node and cleancss versions match up?

Tims-MacBook-Pro:clean-css TimPeterson$ bin/cleancss -v
0.4.2
Tims-MacBook-Pro:clean-css TimPeterson$ node -v
v0.4.12
MacOSX 10.7.5


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants