Refactor get_formatters_grouped

httpie · Sep 1, 2019 · bd3208c · bd3208c
1 parent 4dffac7
commit bd3208c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/httpie/plugins/base.py b/httpie/plugins/base.py
@@ -89,6 +89,7 @@ def supports(cls, mime):
 
 
 class FormatterPlugin(BasePlugin):
+    group_name = 'format'
 
     def __init__(self, **kwargs):
         """

diff --git a/httpie/plugins/manager.py b/httpie/plugins/manager.py
@@ -1,4 +1,5 @@
 from itertools import groupby
+from operator import attrgetter
 from typing import Dict, List, Type
 
 from pkg_resources import iter_entry_points
@@ -51,12 +52,11 @@ def get_formatters(self) -> List[Type[FormatterPlugin]]:
         return self.filter(FormatterPlugin)
 
     def get_formatters_grouped(self) -> Dict[str, List[Type[FormatterPlugin]]]:
-        groups = {}
-        for group_name, group in groupby(
-            self.get_formatters(),
-            key=lambda p: getattr(p, 'group_name', 'format')):
-            groups[group_name] = list(group)
-        return groups
+        return {
+            group_name: list(group)
+            for group_name, group
+            in groupby(self.get_formatters(), key=attrgetter('group_name'))
+        }
 
     def get_converters(self) -> List[Type[ConverterPlugin]]:
         return self.filter(ConverterPlugin)