Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unnecessary multiple import statements #1466

Merged
merged 1 commit into from Jan 15, 2023

Conversation

@jkbrzt
Copy link
Member

jkbrzt commented Jan 15, 2023

Please rebase your branch on top of master to eliminate those unrelated test failures.

@codecov-commenter
Copy link

Codecov Report

Base: 97.28% // Head: 94.63% // Decreases project coverage by -2.65% ⚠️

Coverage data is based on head (cbf23ae) compared to base (4d7d6b6).
Patch coverage: 91.07% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1466      +/-   ##
==========================================
- Coverage   97.28%   94.63%   -2.66%     
==========================================
  Files          67      113      +46     
  Lines        4235     7676    +3441     
==========================================
+ Hits         4120     7264    +3144     
- Misses        115      412     +297     
Impacted Files Coverage Δ
httpie/output/ui/man_pages.py 0.00% <0.00%> (ø)
httpie/output/ui/rich_utils.py 0.00% <0.00%> (ø)
tests/test_binary.py 100.00% <ø> (ø)
tests/test_sessions.py 99.70% <ø> (-0.30%) ⬇️
tests/test_ssl.py 92.59% <ø> (-2.35%) ⬇️
tests/test_stream.py 100.00% <ø> (ø)
tests/test_tokens.py 100.00% <ø> (ø)
tests/test_update_warnings.py 99.14% <ø> (ø)
tests/test_uploads.py 96.70% <ø> (-3.30%) ⬇️
tests/test_xml.py 97.56% <ø> (-0.06%) ⬇️
... and 106 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nishantsikarwar
Copy link
Contributor Author

@jakubroztocil i have updatd the PR can you review it now

Best Regards,
Nishant

@jkbrzt jkbrzt merged commit b16392f into httpie:master Jan 15, 2023
@jkbrzt
Copy link
Member

jkbrzt commented Jan 15, 2023

@nishantsikarwar thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants