Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compaibility with Dayjs #183

Open
hassan-jahan opened this issue Sep 8, 2019 · 3 comments
Open

Compaibility with Dayjs #183

hassan-jahan opened this issue Sep 8, 2019 · 3 comments

Comments

@hassan-jahan
Copy link

Hi,

First of all, thank you for your great job. Is there any plan to make it compatible with dayjs? It's just like momentjs with the same API but more modern and lightweight.

Take a look here:
https://github.com/iamkun/dayjs

and here:
iamkun/dayjs#529

@alitaheri
Copy link
Member

I would suggest using the core library (https://github.com/jalaali/jalaali-js) to build a new integration rather than changing this one to support 2 libraries, whchi would utterly defeat the purpose. even incompatible with the name (moment-jalaali).

@hassan-jahan
Copy link
Author

The point is most of momentjs plugins are already compatible. I mean authors do nothing for that because the API is (almost) identical. In fact, the second link above suggests to rename moment to dayjs and that's it. But regarding this repo, I think there is a problem with one or two functions.

@alitaheri
Copy link
Member

even if there were no problem at all. there is no guarantee that things will stay the same. and if things are that similar a simple copy/paste + new repo would be a much better solution. this way we can prevent future divergence should that occur. and it will be easier to track the issues, maintain the project and write tests when they reside in two different repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants