Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show change only during weekdays? #43

Closed
Qwarkk6 opened this issue Jun 7, 2022 · 6 comments
Closed

Show change only during weekdays? #43

Qwarkk6 opened this issue Jun 7, 2022 · 6 comments
Labels
PR welcome

Comments

@Qwarkk6
Copy link

Qwarkk6 commented Jun 7, 2022

I love the module, just wondering if it would be possible to add a feature where the percentage change in stock value is only visible during weekdays and not on weekends.
@jalibu
Copy link
Owner

jalibu commented Jun 7, 2022

It depends on your donation if I find the time to implement that ;-)

I am also always open for Pull Requests

@jalibu
Copy link
Owner

jalibu commented Jun 10, 2022

@Qwarkk6 what do you think about an option, that checks the last change age and ignores it if it is older than 24h?

@jalibu
Copy link
Owner

jalibu commented Jun 10, 2022

@Qwarkk6 please checkout the development branch

@jalibu
Copy link
Owner

jalibu commented Jun 17, 2022

@Qwarkk6 feedback please

@jalibu
Copy link
Owner

jalibu commented Jun 18, 2022

fixed

@jalibu jalibu closed this as completed Jun 18, 2022
@Qwarkk6
Copy link
Author

Qwarkk6 commented Jun 18, 2022

Sorry, haven't been active on here for some time. Thank you for taking a look at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PR welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Qwarkk6 @jalibu