Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimeEnvironment should use def instead of val for abstract members #512

Closed
danielkza opened this issue Jan 17, 2015 · 1 comment
Closed

Comments

@danielkza
Copy link
Contributor

The RuntimeEnvironment trait has all it's components as val. That means they cannot be overriden by a defs or lazy val, removing quite a bit of flexibility. For example, I wanted each of my controllers to register an event listener if desired, and do user-aware actions from some of them. But that is not possible because eventListeners is immutable. It also happens to be a List when it should be a Seq so it could be overridden by any type of collection.

@jaliss jaliss closed this as completed in 87d284f Nov 29, 2015
@jaliss
Copy link
Owner

jaliss commented Nov 29, 2015

@danielkza just implemented this. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants