[BUG] Leaving ghost icons for start movement only on player side

[bushibot]

Describe the bug
Players were left seeing ghost icons for movement start location. As the GM I code not see this, I had to have them send a snap. It appears that player view was not policing the graphic after turn change....
https://media.discordapp.net/attachments/729428633885737031/734481323288297482/Capture.JPG

Environment Details
Foundry VTT Version: Example 0.6.5
Turn Marker Version: Example 2.6.9

To Reproduce
Not sure, just normal play.

Expected behavior
A clear and concise description of what you expected to happen.
Start icons icons should clean up on next player/mob turn.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

[LyricalStreetPoet]

I just did a test and can confirm this is still happening.

[bushibot]

I'm still seeing these phantom zero feet icons. I can't seem to clean them up either.

[zarmstrong]

I saw this, too, as a GM.

[k3tw13z3l]

Yeah I see them too. It are just tiles so you can delete with the tiles tool.

[9ryex5]

Same, this is also happening as GM

[JamzTheMan]

Yea, just logged on and saw like 30 of these from last nights session. Will turn it off for now it looks like.

[bushibot]

You can removed them at the tile layer, but yeah it’s extra work. Is their any alternative module?

[kckaiwei]

@bushibot looking into the issue, any extra information would be helpful, since I don't exactly have an exact steps to reproduce. That being said, I've seen this behavior happen myself, and I've only just recently took over stewardship of TurnMarker on Foundry, so I'm still getting familiar with the code.

An updated repo is here:
https://github.com/kckaiwei/TurnMarker-alt

If you're downloading from FoundryVTT, you will get 2.7.0 automatically, since Foundry gave me control of the repo.

[kckaiwei]

I've narrowed it down to:
await canvas.scene.deleteEmbeddedEntity('Tile', tile._id); isn't deleting, even though I can confirm the ID being passed is correct, and deleteEmbeddedEntity is being called.

[bushibot]

Seems tied to how combat tracker updates. Some times I can go back to the last PC and then back and it cleans up, but not always. It’s like something I’m doing as GM causes it to skip.

[zarmstrong]

should there be an await on Marker.deleteStartMarker() here https://github.com/Brunhine/TurnMarker/blob/b3f5a06219902de76f883b54be1605b0fcd285bf/src/scripts/turnmarker.js#L74

[kckaiwei]

I've done and added awaits to all of them since it seemed like they didn't have any. No change.

I'm suspecting its a netcode thing now, but not sure. Since after moving out of preHooks (which apparently can have race issues), I'm getting problems where controlling a PC that's got a client connected can create multiple startmarkers if I move fast enough when the turn changes.

I haven't been getting issues for the active being left behind at least, so disabling startmarker may just be the way to go for now.

[kckaiwei]

From my testing, I've fixed it, and released the bugfix in 2.7.1. My repo is the new main repo for Foundry, so if you just update in game, you should get it.

Any feedback is welcome. Let me know if any other bugs cropped up. From testing in a new world and some dummy characters there seem to be no issues, but haven't done an extended session yet.
kckaiwei/TurnMarker-alt#13

I'm going to stop following this dead repo and move to mine. Feel free to add any bugs/issues you want fixed as I triage these old issues.

[bushibot]

Thank you, will check and move to new repo should there be anything to report on.

[RayakiTheTurtle]

Hello, I keep having the issue that the start markers keep staying on the map after combat has ended.
It happens to both the GM and the players, but more often to the players. I could not find a regular pattern for when it happens. When I tried to reproduce it I could only make it happen on the player side, not the GM side.

That screenshot shows tokens as they appear to the GM and the player currently.