Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix download broken links + update download links to v2.1.0 #795

Merged
merged 1 commit into from Oct 19, 2023

Conversation

ramigs
Copy link
Contributor

@ramigs ramigs commented Oct 19, 2023

fixing broken download links for Mac and Windows.

also noticed that a new version was released yesterday, so updated the links to point to v2.1.0.
pls let me know if keeping v2.0.0 is intended and I'll update the PR.

Copy link
Owner

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for catching this. I did forget to update the README with the latest release.

@jamaljsr jamaljsr merged commit 771eab1 into jamaljsr:master Oct 19, 2023
3 checks passed
@ramigs ramigs deleted the fix/download-urls-in-readme branch October 19, 2023 20:28
@ramigs
Copy link
Contributor Author

ramigs commented Oct 20, 2023

btw, to avoid having to manually update at each release, has it been considered linking to the latest release? https://docs.github.com/en/repositories/releasing-projects-on-github/linking-to-releases

or is it unsuitable because some releases are rc and therefore not to be linked?
if so, maybe could be considered introducing tag stable and linking to it.

however, this change would require file names to not have the version anymore (not sure if it's a hard requirement)

@jamaljsr
Copy link
Owner

Thanks for the suggestion. I would prefer to keep the version in the file names. This hasn't been an issue with past releases. I was just rushing this time and did the release without referring to the documented release process, which was a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants