Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Node.js version 20 #827

Merged
merged 14 commits into from Jan 9, 2024

Conversation

kelvinator07
Copy link
Contributor

@kelvinator07 kelvinator07 commented Jan 5, 2024

Closes #(820)

Description

Added support for Node.js version 20

Copy link
Owner

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this PR. This update was long overdue.

I see the CI build failing. It looks like the NodeJS version in the workflow needs to be updated.

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/components/network/NetworkActions.tsx Outdated Show resolved Hide resolved
@kelvinator07 kelvinator07 changed the title Added support for Node.js version 20.10.0 LTS Added support for Node.js version 20 Jan 8, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1152c17) 100.00% compared to head (509abd8) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #827   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          139       139           
  Lines         4356      4386   +30     
  Branches       823       852   +29     
=========================================
+ Hits          4356      4386   +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@jamaljsr jamaljsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the latest changes. LGTM 👌

Thanks for this long awaited fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants