just clearing the cache doesn't shut down the channel consumers. Swit…

…ching to unregisterAll
hapifhir · Feb 3, 2019 · 4a49a93 · 4a49a93
1 parent 84db66d
commit 4a49a93
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 14 deletions.
diff --git a/...tion/src/main/java/ca/uhn/fhir/jpa/subscription/module/cache/ActiveSubscriptionCache.java b/...tion/src/main/java/ca/uhn/fhir/jpa/subscription/module/cache/ActiveSubscriptionCache.java
@@ -20,7 +20,6 @@
  * #L%
  */
 
-import com.google.common.annotations.VisibleForTesting;
 import org.apache.commons.lang3.Validate;
 
 import java.util.ArrayList;
@@ -70,9 +69,4 @@ public void unregisterAllSubscriptionsNotInCollection(Collection<String> theAllI
 			}
 		}
 	}
-
-	@VisibleForTesting
-	void clearForUnitTests() {
-		myCache.clear();
-	}
 }
diff --git a/...ription/src/main/java/ca/uhn/fhir/jpa/subscription/module/cache/SubscriptionRegistry.java b/...ription/src/main/java/ca/uhn/fhir/jpa/subscription/module/cache/SubscriptionRegistry.java
@@ -24,7 +24,6 @@
 import ca.uhn.fhir.jpa.model.interceptor.api.IInterceptorBroadcaster;
 import ca.uhn.fhir.jpa.model.interceptor.api.Pointcut;
 import ca.uhn.fhir.jpa.subscription.module.CanonicalSubscription;
-import com.google.common.annotations.VisibleForTesting;
 import org.apache.commons.lang3.Validate;
 import org.hl7.fhir.instance.model.api.IBaseResource;
 import org.hl7.fhir.instance.model.api.IIdType;
@@ -113,7 +112,7 @@ public void unregisterSubscription(IIdType theId) {
 	}
 
 	@PreDestroy
-	public void preDestroy() {
+	public void unregisterAllSubscriptions() {
 		unregisterAllSubscriptionsNotInCollection(Collections.emptyList());
 	}
 
@@ -156,9 +155,4 @@ public boolean unregisterSubscriptionIfRegistered(IBaseResource theSubscription,
 	public int size() {
 		return myActiveSubscriptionCache.size();
 	}
-
-	@VisibleForTesting
-	public void clearForUnitTests() {
-		myActiveSubscriptionCache.clearForUnitTests();
-	}
 }
diff --git a/...hir/jpa/subscription/module/standalone/BaseBlockingQueueSubscribableChannelDstu3Test.java b/...hir/jpa/subscription/module/standalone/BaseBlockingQueueSubscribableChannelDstu3Test.java
@@ -73,7 +73,7 @@ public void beforeReset() {
 		ourCreatedObservations.clear();
 		ourUpdatedObservations.clear();
 		ourContentTypes.clear();
-		mySubscriptionRegistry.clearForUnitTests();
+		mySubscriptionRegistry.unregisterAllSubscriptions();
 		if (ourSubscribableChannel == null) {
 			ourSubscribableChannel = mySubscriptionChannelFactory.newDeliveryChannel("test", Subscription.SubscriptionChannelType.RESTHOOK.toCode().toLowerCase());
 			ourSubscribableChannel.subscribe(myStandaloneSubscriptionMessageHandler);