Try to reuse index rows in JPA server #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fil512
reviewed
Dec 5, 2018
...hir-jpaserver-base/src/test/java/ca/uhn/fhir/jpa/dao/r4/FhirResourceDaoR4QueryCountTest.java
Outdated
Show resolved
Hide resolved
hapi-fhir-jpaserver-model/src/main/java/ca/uhn/fhir/jpa/model/entity/BaseResourceIndex.java
Show resolved
Hide resolved
| } | ||
|
|
||
| T entityToReuse = theIndexesToRemove.remove(theIndexesToRemove.size() - 1); | ||
| entityToReuse.populateFrom(theIndexesToAdd.get(addIndex)); |
There was a problem hiding this comment.
Using a populateFrom() strategy runs the risk of missing data if new fields are added in the future. This risk could be avoided by copying the id from entityToReuse to theIndexesToAdd.get(addIndex). Might need to do some hibernate magic if we're in session (detach / reattach type stuff).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.