Resthook subscription implementation, event driven websocket subscrip… #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion implementation, Tminus subscription support, notification on delete
|
This looks awesome. Thanks for putting it on GitHub, that makes it so much easier for me to review. :) One thing to note, our build will automatically change the license headers to reassign the copyright of the contributed files to University Health Network. Please let me know if this is an issue. Merging now! |
jamesagnew
added a commit
that referenced
this pull request
May 21, 2017
Squashed commit of the following:
commit 9d6d5e92dabb75c4eb185b061d20f487b8856795
Author: James <jamesagnew@gmail.com>
Date: Sun May 21 15:27:26 2017 -0400
Get subscriptions working
commit 6bccdd7
Author: James Agnew <jamesagnew@gmail.com>
Date: Sun May 21 14:37:40 2017 -0400
Work on subscription
commit 129f4c9
Author: James <jamesagnew@gmail.com>
Date: Sat May 20 19:58:11 2017 -0400
Work on merging subscription
|
Hi @javajeff - Would you mind to review commit a13247a ? I've made some modifications to this, mostly around making the unit tests run during the normal build by refactoring them a bit and moving them into the hapi-fhir-jpaserver-base project. I also swapped the interceptor to extend IServerOperationInterceptor which replaces IJpaServerInterceptor. |
jamesagnew
added a commit
that referenced
this pull request
May 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tion implementation, Tminus subscription support, notification on delete