Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sources and resource generator mojo which doesn't use value sets. #852

Merged
merged 2 commits into from Dec 13, 2018

Conversation

splatch
Copy link
Contributor

@splatch splatch commented Feb 19, 2018

I've attempted to reorganize a little bit the way how configuration is being processed because there was a lot of duplicated code. It is still far from being perfect but it works.

@coveralls
Copy link

coveralls commented Feb 19, 2018

Coverage Status

Coverage increased (+0.05%) to 72.939% when pulling e9d2641 on splatch:3.2.x into 2396f43 on jamesagnew:master.

@jamesagnew
Copy link
Collaborator

Hi @splatch - What is the purpose of this? I'm not really clear on why one would need a version of the structure generator that doesn't use valuesets?

@splatch
Copy link
Contributor Author

splatch commented May 23, 2018

Hey James,
This particular generator works without issues with STU3 resources. Due to changes in value set handling tinder doesn't work with STU3 and is compatible only with DSTU2.

@jamesagnew jamesagnew merged commit 1afe36e into hapifhir:master Dec 13, 2018
@jamesagnew
Copy link
Collaborator

Hi @splatch - I'm merging this as it seems non-intrusive and I assume you have a use for it. I would recommend if you can that you submit a further PR with a unit test though to avoid this being broken in the future.

@splatch
Copy link
Contributor Author

splatch commented Dec 14, 2018

@jamesagnew thank you very much for including this one. We stayed with @hzbarcea on 3.2.x since this PR was made. We needed it for custom code generators based only on resource definitions. Despite of support for custom code generation available in FHIR spec we could get it over.

@hzbarcea
Copy link

Thanks @jamesagnew and @splatch !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants