New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unecessary reference to javassist. #864

Merged
merged 1 commit into from Mar 23, 2018

Conversation

Projects
None yet
3 participants
@splatch
Contributor

splatch commented Feb 26, 2018

By accident I've found that hapi-fhir-base pulls in javassist without need. This might help (a little) with #826. :-)

@coveralls

This comment has been minimized.

coveralls commented Feb 26, 2018

Coverage Status

Coverage increased (+0.003%) to 72.918% when pulling 9125a78 on splatch:master into 4ef07d2 on jamesagnew:master.

@splatch

This comment has been minimized.

Contributor

splatch commented Mar 20, 2018

I've updated PR so it's on top of current master. I did a complete build without javassist dependency (simply removed it) and none of tests have failed. This commit reduces runtime dependencies of hapi-base by one item.

@jamesagnew

This comment has been minimized.

Owner

jamesagnew commented Mar 23, 2018

Looks good, merging now! Thanks!

@jamesagnew jamesagnew merged commit d9fcf1e into jamesagnew:master Mar 23, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 72.918%
Details

jamesagnew added a commit that referenced this pull request Mar 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment