Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Add the version number in the build file #27

Closed
stof opened this issue May 22, 2013 · 4 comments
Closed

[Suggestion] Add the version number in the build file #27

stof opened this issue May 22, 2013 · 4 comments

Comments

@stof
Copy link

stof commented May 22, 2013

It would be good to have a comment in the build file with the version number, allowing to check whether an update is needed or no.
And it would be great if the website displays the latest version so that we can know about it.

Additionally, you might want to create tags for the 2.0.x releases in the repo, as you used to do for the 1.x versions.

@jamesallardice
Copy link
Owner

Thanks, these are all very useful suggestions and things I will definitely look at adding in the next release.

@jamesallardice
Copy link
Owner

I've pushed up a commit that adds a version comment to the minified output file. I've also gone back and added tags for each stable release since (and including) 2.0.0.

I will update the website with version info when I release the next version (hopefully tomorrow).

@stof I'm not sure what adding the version number to the build file would do - it's already available in package.json (the standard file to check for such metadata). Would adding it to the build file (I assume you mean Gruntfile.js) be any more helpful to you? If so, I'm happy to add it.

@stof
Copy link
Author

stof commented Jun 16, 2013

no, I meant the file being built. My app using this library only contains the JS file I downloaded, not the package.json file. The comment is fine

@jamesallardice
Copy link
Owner

In that case I'll close the issue now. Thanks again for the suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants