New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add propertychange handlder ,and structure change #7
Conversation
By the sound of it, you've basically done what I've been meaning to do for a while now! I'll have a proper look through your changes as soon as I get a chance and hopefully we can merge it in. Thanks. |
@@ -440,6 +419,7 @@ var Placeholders = (function () { | |||
//Expose public methods | |||
return { | |||
init: init, | |||
refresh: updatePlaceholders | |||
refresh: updatePlaceholders, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updatePlaceholders
method no longer exists, so this throws an error.
Just ran into this issue - "updatePlaceholder doesn't process the form submit for new added input element", so +1 for this. |
@ahutchings I've pushed up a fix for that issue. I'm reluctant to merge in this full pull request due to the fact it contains at least one obvious error. I've been waiting for the opener to get back to me before I'll consider merging. But if you grab the latest version, the new form issue should be solved. |
Thanks, your fix is working great! |
@guirong Please let me know if you are able to go through your pull request and sort out any errors. It's been over a month now so if I don't hear back from you soon I'm going to close this. When I get a chance I may use bits of your code to simplify the library but I'm reluctant to merge this in with obvious errors. |
@jamesallardice sorry for that, I will fix it as soon as possible! |
@@ -440,6 +419,7 @@ var Placeholders = (function () { | |||
//Expose public methods | |||
return { | |||
init: init, | |||
refresh: updatePlaceholders | |||
refresh: createPlaceholders, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace "updatePlaceholders" by "createPlaceholders", as the original "updatePlaceholders" method's function has been replaced by createPlaceholders.
@jamesallardice What's going on? |
here is some changes
in addition, I don't think refresh method has meaning any more, except in the browser don't support properychange event. could you think about it?