Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuring sink using JSON #2

Closed
FantasticFiasco opened this issue Apr 24, 2017 · 2 comments
Closed

Configuring sink using JSON #2

FantasticFiasco opened this issue Apr 24, 2017 · 2 comments

Comments

@FantasticFiasco
Copy link

Hi!

There is a proposal over at Serilog.Settings.Configuration where sink developers would be able to specify an extension point specially designed to support JSON configuration. If this is something you would find beneficial for your sink, please give a thumbs up or something. If not, have a nice day and continue being awesome!
@jamesbascle
Copy link
Owner

I am not particularly worried about it one way or another. I would not be opposed to a well written PR that does such a thing if it were implemented in the core lib.

@jamesbascle jamesbascle reopened this Apr 24, 2017
@FantasticFiasco
Copy link
Author

You are correct, the PR is not a well written specification, and for that I am sorry. It is a tl;rd; of a feature that hopefully would benefit some sink. But if you haven't felt the pain of the current compatibility, it is not for you.

Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesbascle @FantasticFiasco