Skip tests broken for specific or all platforms #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decorates tests that are potentially skipped, as well as broken tests that are always skipped, as being skipped, rather than indicating falsely that these tests have passed (the result of premature return statements prior to any assertions in the tests). This introduces another dependency for Python 2.6, the unittest2 module, which back-ported this functionality from Python 2.7 and Python 3.
|
This is very helpful, thanks a lot! |
martijnvermaat
added a commit
that referenced
this pull request
May 14, 2014
Skip tests broken for specific or all platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests contains changes to skip over several brittle tests brought in with pull request #66. Several of these tests cause the Travis CI jobs to fail on Python 3 and PyPy, as seen in the job following the accepted pull request. These changes will restore the Travis CI jobs to passing status, but with the acknowledgment that certain tests were skipped for certain platforms (Python 3 or PyPy).
This pull request also changes the reporting of several tests aborted by early return statements from the specious status of "ok" to the more accurate status of "skipped".
As the fragility of these tests gets addressed, the skipped status can be removed. For right now, it will help developers to have those tests skipped rather than force them to always expect failing tests and have to parse through the output to see if it includes one of their new tests or not.
This pull request also introduces a new dependency for Python 2.6, the unittest2 backport, for the
@unittest.skipand@unittest.skipUnlessdecorators.