Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cca_zoo.model_selection.GridSearchCV's param_grid parameter should accept any type of iterator #179

Open
JohannesWiesner opened this issue Aug 1, 2023 · 3 comments

Comments

@JohannesWiesner
Copy link
Contributor

With reference to this comment, cca_zoo.model_selection.GridSearchCV's param_grid parameter should accept any type of iterator as dictionary values. Right now, np.array, pd.Series, list and tuple come to my mind. Both np.array and pd.Series can be easily converted into the list type by using their tolist() method (or by calling list() on them). Not sure about other data types. I guess, generally, any object that has the __iter__ and __next__ methods should be fine if it can be converted to a list?

@JohannesWiesner
Copy link
Contributor Author

P.S.: Cannot recall that I had this issue with scikit-learn's GridSearchCV before. How do they handle this case?

@jameschapman19
Copy link
Owner

Fixed this in latest push to main

@jameschapman19
Copy link
Owner

Small fix to work with #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants