This repository has been archived by the owner on Dec 25, 2018. It is now read-only.
This fixes a bug where grumble/bubble does not work if you include it in the head of your page instead of at the very bottom #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you happen to include Bubble.js in the <head> of your DOM, then the $('body') selector may not select an element as it has not been parsed yet. This fixed that bug.
jamescryer
pushed a commit
that referenced
this pull request
Jan 3, 2013
This fixes a bug where grumble/bubble does not work if you include it in the head of your page instead of at the very bottom
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you happen to include Bubble.js in the of your DOM, then the $('body') selector may not select an element as it has not been parsed yet. This fixed that bug.