Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Removed the conditional return statements on method.
Reason is that, we should be able to force it to scroll to the bottom. I'm not even sure why I had it in there in the first place. Other changes: Changed @isdead to @stopped because the former's ambiguity. Added method chaining for the @addEvents method and replaced 'bind' with 'on'. Similar thing done to @removeEvents Cleaned up code and added comments on the @reset method. It may have added a few weight in terms of file size, but I prefer having a comprehensive code that's easy to improve and update. Added explanation to the formula for the scrolling mechanism in the @scroll method. Added makefile for development preview. On a personal note: Seriously, good job guys. I've seen the changes and just wanna say thank you for contributing and helping the plugin work better. Special shoutout to @kristerkari for the continuous updates.
- Loading branch information
6ef76ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure we want
.on
instead of.bind
? It makes the plugin incompatible with jQuery versions older than 1.76ef76ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm good call. Hang on, pushing a commit.
6ef76ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed.
6ef76ca
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!