Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Pages deployment links to incorrect paths #11

Closed
ChrisNeedham24 opened this issue Jun 22, 2021 · 4 comments · Fixed by #27 or #44
Closed

GitHub Pages deployment links to incorrect paths #11

ChrisNeedham24 opened this issue Jun 22, 2021 · 4 comments · Fixed by #27 or #44
Labels
bug Something isn't working UI

Comments

@ChrisNeedham24
Copy link
Collaborator

ChrisNeedham24 commented Jun 22, 2021

While the links within the app work, if you refresh any of the non-home pages, you'll get a 404.

@jamesgiu
Copy link
Owner

jamesgiu commented Jun 22, 2021

Yeah it does, we should be able to prepend routes with the 'quick-hit' path to cheese this and get around it 😂

(Though the real solution would probably entail using process env variables for deploy vs start and have it change the base path for a GH pages deployment)

I'm gonna do a bunch of tidy up tonight including a few bug fixes so I might include it (unless you're already on it)

@jamesgiu jamesgiu self-assigned this Jun 22, 2021
@jamesgiu jamesgiu added bug Something isn't working UI labels Jun 22, 2021
@ChrisNeedham24
Copy link
Collaborator Author

Yeah it does, we should be able to prepend routes with the 'quick-hit' path to cheese this and get around it 😂

(Though the real solution would probably entail using process env variables for deploy vs start and have it change the base path for a GH pages deployment)

I'm gonna do a bunch of tidy up tonight including a few bug fixes so I might include it (unless you're already on it)

I was planning on doing it but go right ahead. That's the way I was thinking of doing it anyway haha

@jamesgiu
Copy link
Owner

jamesgiu commented Jun 22, 2021

Oh dude ❤️! If you free up and are itching for more, feel free to go for it 👍

You should be able to deploy to GH pages with npm run deploy

@jamesgiu jamesgiu linked a pull request Jun 22, 2021 that will close this issue
@jamesgiu
Copy link
Owner

So I merged some changes to do with setting a configurable base path, still works, but didn't solve the problem. I reckon it's a GH pages thing now

@jamesgiu jamesgiu removed their assignment Jun 22, 2021
@jamesgiu jamesgiu linked a pull request Jun 24, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI
Projects
None yet
2 participants