Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly implement tests for ease-of-refactoring #11

Closed
jameshball opened this issue Nov 12, 2020 · 2 comments
Closed

Properly implement tests for ease-of-refactoring #11

jameshball opened this issue Nov 12, 2020 · 2 comments

Comments

@jameshball
Copy link
Owner

Tests required for the following classes:

  • Shape
    • Use mock objects?
  • Shape subclasses
    • Line, Vector2, Ellipse, Curves etc.
  • SvgParser
  • ObjParser

Why this is required:

  • Implementation of CI
  • Make refactoring more reliable and far quicker
  • Ensure implementing new features is easy
@jameshball
Copy link
Owner Author

jameshball commented May 15, 2021 •
edited
Loading

Running into lots of issues with regards to making the project modular with a test suite. JUnit is not a modular dependency (I believe) and makes it extremely finicky to use it with jlink.

@jameshball
Copy link
Owner Author

Implementing tests is now possible after transitioning osci-render to a non-modular program for ease of packaging.

This means I can easily add new libraries without worrying about issues with non-modular libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jameshball