Controlling osci-render with a keyboard rather than a mouse

[klrjhthertjrklrjhthertjr]

I have Osci-Render installed on Windows 10 using osci-render-1.33.2.exe. I connected a MIDI keyboard and was able to use it with Osci-Render. It could control the frequency with the keyboard so that I was able to play notes. However, when attempting to associate a MIDI key with a slider, I run into an issue. I click reset MIDI and then click on the MIDI button next to the slider. The MIDI button turns red and I press the key I would like to associate. The MIDI button stays red and it starts to play my note instead of associating. I cannot figure out whether I'm doing something wrong or if this is a bug.

My logs say this, if relevant:
Jan 21, 2023 1:46:46 AM com.sun.javafx.application.PlatformImpl startup
WARNING: Unsupported JavaFX configuration: classes were loaded from 'unnamed module @2113c62d'
Jan 21, 2023 1:46:50 AM sh.ball.audio.engine.XtAudioEngine getService
SEVERE: No XtAudio service found

[jameshball]

Thanks for making an issue and providing logs :) Currently the midi mapping to sliders is only supported with CC channels, so if you have a slider or knob on your keyboard that sends CC messages, you'll be able to use that with it.

What's the behaviour you'd like to see? Would you want the key's volume/velocity to control the position of the slider when it's mapped to it, or just enable/disable the effect?

[klrjhthertjrklrjhthertjr]

Ah, I feel a bit stupid now, of course it would only work with sliders.
When I was using the software, I think the functionality I was expecting was as follows.
Like you said; enable/disable. When the key is pressed it either enables/disables or it toggles between zero(or the default value) and whatever value was last set on the slider. For example, for .obj settings, like Rotate x, pressing the key might toggle between zero and the last value the user set.
It might be nice to be able to map standard keyboard keys to different functions. I was trying to get away from using the GUI, while a really nice GUI, I like my tactile keys. There's a synth software I've used; Helm, which maps the home row on the keyboard so that you can play them like a midi keyboard.
Thanks so much for the software, it's really awesome!

[jameshball]

Thanks for the feedback and I agree it would be nice to have more keyboard controls! I think it makes sense to just add more keyboard support in general as it's currently very mouse-based as you've suggested.

Currently rewriting osci-render in C++ so can't promise this will be added any time soon but I'll definitely try and think about it for the rewrite!