Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting issue #31

Closed
francisbegbie opened this issue Sep 6, 2022 · 5 comments
Closed

Formatting issue #31

francisbegbie opened this issue Sep 6, 2022 · 5 comments

Comments

@francisbegbie
Copy link

Version: 3.2.1-fdroid
Android: 11 (RQ3A.211001.001)

The regular format (Quote -> blank line -> Author -> blank line -> Count) is not adhered to whenever the widget displays quotes from 'Top Quotes'. As seen in the screenshot, the format changes to Quote -> Dash -> Author (on the same line) -> blank line -> Count.

Note: Setting is Configuration / Quotations / All. The above issue is encountered only when the app randomly picks quote from within 'Top Quotes'. No issue with other quotes.

Screenshot_20220903-092116

Screenshot_20220903-092123

@jameshnsears
Copy link
Owner

Hi - thanks for raising this issue and supplying the screenshots.

This is the case with quotes taken from https://www.reddit.com/r/quotes/ - /r/quotes/top

Basically I queried reddit's API - using python's praw library - for the top 1000 quotes. What comes back is a mess - excluding about 400 duplicates within the 1000 - the actual content doesn't split quotation from source.

If I had time I could manually do the split - but at the moment I haven't.

If someone else mentions or comments on this issue then I'll find time sooner rather than later. For the moment I'll keep this issue, open, under Enhancements in https://github.com/jameshnsears/QuoteUnquote/projects/1

@francisbegbie
Copy link
Author

I know this would be time consuming if done manually. Not urgent, just wanted to bring to your attention.

@jameshnsears jameshnsears moved this from Enhancements to In progress in QuoteUnquote - raised by users :-) Dec 4, 2022
@jameshnsears jameshnsears moved this from In progress to Needs Clarification in QuoteUnquote - raised by users :-) Dec 5, 2022
@jameshnsears jameshnsears moved this from Needs Clarification to Enhancements in QuoteUnquote - raised by users :-) Dec 5, 2022
@jameshnsears
Copy link
Owner

b6p5kzq3@...

One of the many things I like about this app is that I can click on the authors name to get a Wikipedia page about them. Unfortunately this is currently only possible if I select all or a specific author and not possible if I use "/r/quotes/top". Any chance of parsing the individual authors that appear here and adding the wikipedia link to it?

@jameshnsears
Copy link
Owner

Pushed a solution to this to Google Play and F-Droid. The Source is still called /r/quotes/top but if it's underlined it takes you to the relevant wikipedia article.

@francisbegbie
Copy link
Author

Thank you James.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants