Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center quotes & source in same line #35

Closed
KiritoStorm opened this issue Sep 11, 2022 · 4 comments
Closed

Center quotes & source in same line #35

KiritoStorm opened this issue Sep 11, 2022 · 4 comments

Comments

@KiritoStorm
Copy link

KiritoStorm commented Sep 11, 2022

So quotes can be really long and short, so it would be nice to have the option to center the text, vertically and horizontally.
For me I would maybe do this as the default behavior.

Also it would also be nice then to have the option that the source is in the same line:
[Quote] - [Source]

@jameshnsears jameshnsears self-assigned this Sep 21, 2022
@jameshnsears jameshnsears added the question Further information is requested label Sep 21, 2022
@jameshnsears
Copy link
Owner

Hi - can you elaborate a bit more on this centering idea? Just so that its a bit clearer to me. A simple example would help.

A "compact view" with the quotation and source on the same line sounds possible (just so long that it preserves the link to wikipedia). I'll likely implement this in the future, after version 4.2.0 - as it reads like a good idea :-)

@KiritoStorm
Copy link
Author

KiritoStorm commented Sep 23, 2022

image

Imagine something like that without the background and the text in the center of the image and without typos :D

@jameshnsears jameshnsears moved this from Needs Clarification to In progress in QuoteUnquote - raised by users :-) Nov 16, 2022
@jameshnsears jameshnsears removed the question Further information is requested label Nov 18, 2022
@jameshnsears jameshnsears moved this from In progress to Final Testing in QuoteUnquote - raised by users :-) Dec 1, 2022
@jameshnsears
Copy link
Owner

Hi - I've released 4.3.0 (it might take a day or so for it to appear in Google Play / F-Droid): it contains a center option for the Quotation & Source lines.

I wasn't able to combine the Quotation & Source into a single line. As far as I can tell it's not possible to separate a "tap" (two are required: one for the Configuration screen + one for any possible Wikipedia link) between different areas on a block of text that all reside in the same line.

Anyhow, thanks for raising this issue, I think it improves things.

I'll close this issue, but if you spot any related defect please raise a new issue :-)

@jameshnsears jameshnsears moved this from Final Testing to Released / Done in QuoteUnquote - raised by users :-) Dec 2, 2022
@KiritoStorm
Copy link
Author

KiritoStorm commented Dec 3, 2022

Thank you, it looks definitely better for me now ❤️
The only thing that I would change in addition is to also be able to center the text vertically.
So you don't have so much space between the text and the toolbar. 🤔

IMG_20221203_110926

A other idea would be to put the author in the next line (if there is one) but I can create seperate issue for that. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Released / Done
Development

No branches or pull requests

2 participants