routes: do not override response headers #3
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response headers in dash-2.4 is not a dictionary but Headers.
It also not ideal to override the member but amend values.
File "/home/alonbl/.local/lib/python3.10/site-packages/flask/app.py", line 1889, in process_response
response = self.ensure_sync(func)(response)
File "/home/alonbl/.local/lib/python3.10/site-packages/dash/dash.py", line 1820, in _after_request
response.headers.add("Server-Timing", value)
AttributeError: 'dict' object has no attribute 'add'
Signed-off-by: Alon Bar-Lev alon.barlev@gmail.com