Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch deleted after "deploy" #14

Closed
InDieTasten opened this issue Aug 24, 2019 · 2 comments · Fixed by #15
Closed

Branch deleted after "deploy" #14

InDieTasten opened this issue Aug 24, 2019 · 2 comments · Fixed by #15
Assignees
Labels
feature request ✨ New feature or request

Comments

@InDieTasten
Copy link

Describe the bug

Action creates gh-pages branch, pushes the desired files to it, but then deletes it again after assertion failed: test FOLDER = FODER

Reproduce

My workflow yaml

Expected behavior

That the gh-pages branch will not be deleted at the end of the deployment

Screenshots / Logs

Logs

Additional Comments

The files pushed to the branch seem correct to me. The first weird log entry to me is

assertion failed: test Breadstone.Blazor/bin/Release/netstandard2.0/publish/Breadstone.Blazor/dist = ./Breadstone.Blazor/bin/Release/netstandard2.0/publish/Breadstone.Blazor/dist

Solution

This led me to believe, that the ./ in my FOLDER path led to this problem, which is what was the case. So maybe this can be put into the documentation, or maybe the action can be able to accept leading ./

@JamesIves
Copy link
Owner

JamesIves commented Aug 25, 2019

Thanks for the report! You're spot on, this is to do with ./ in the file path.

I think this would make a good documentation addition, as git subtree doesn't play nicely with this syntax according to this Stack Overflow post. I would rather avoid the action doing any form of string replacement as I feel it could be pretty error prone.

@JamesIves JamesIves self-assigned this Aug 25, 2019
@JamesIves JamesIves added bug 🐦 Something isn't working feature request ✨ New feature or request and removed bug 🐦 Something isn't working labels Aug 25, 2019
@JamesIves
Copy link
Owner

JamesIves commented Aug 25, 2019

This was fixed in #15 and released in version 2.0.1 - thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request ✨ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants