Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support actions/checkout@v2 #99

Closed
JamesIves opened this issue Dec 30, 2019 · 3 comments
Closed

Support actions/checkout@v2 #99

JamesIves opened this issue Dec 30, 2019 · 3 comments
Labels
dependencies Pull requests that update a dependency file feature request ✨ New feature or request help wanted 📲 Extra attention is needed researching 📒 Currently researching potential fixes. version 3 Issues related to version 3 of this action.
Milestone
3.2.0

Comments

@JamesIves
Copy link
Owner

Currently this action requires you to use actions/checkout@v1 instead of the latest release. This should be investigated so v2 is also supported without causing any breaking changes.

My guess is it’s related to the token config persistence. It’s likely that the GITHUB_TOKEN variable is being included automatically by the action which is causing some funky behavior in subsequent builds. I can investigate this more when I get home, I think we may need to change the variable name for GITHUB_TOKEN.

Originally posted by @JamesIves in #98
@JamesIves JamesIves changed the title Support @actions/checkout@v2 Support actions/checkout@v2 Dec 30, 2019
@JamesIves JamesIves added dependencies Pull requests that update a dependency file feature request ✨ New feature or request help wanted 📲 Extra attention is needed version 3 Issues related to version 3 of this action. labels Dec 30, 2019
@JamesIves
Copy link
Owner Author

Related: actions/checkout#132

@JamesIves JamesIves added this to the 3.2.0 milestone Jan 8, 2020
@JamesIves
Copy link
Owner Author

JamesIves commented Jan 12, 2020 •
edited

The action will succeed in deployment with checkout@v2, but the changes will not trigger a page build. I'm still looking into this issue for a 3.2.0 release.

@JamesIves JamesIves added the researching 📒 Currently researching potential fixes. label Jan 12, 2020
@JamesIves
Copy link
Owner Author

Documentation has been updated for this. You must set persist-credentials: false if you want to use actions/checkout@v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file feature request ✨ New feature or request help wanted 📲 Extra attention is needed researching 📒 Currently researching potential fixes. version 3 Issues related to version 3 of this action.
Projects
None yet
Milestone
3.2.0
Development

No branches or pull requests
1 participant
@JamesIves