Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider including queues and queue admins in source code rather than database #31

Open
jkloosterman opened this issue Jun 6, 2019 · 1 comment

Comments

@jkloosterman
Copy link
Collaborator

This way, administrators and courses could be added and removed using pull requests rather than needing to manually edit the database or create functionality to edit the database with a web interface.

For queues, we would want to be careful that we didn't lose information about which queue students were signed up on when analyzing the stack through a database dump.

@jamesjuett
Copy link
Owner

jamesjuett commented Jun 6, 2019

I think a web interface would likely be the better solution for users of the queue.

It shouldn't be too bad to add additional configuration options to the web interface. Existing frontend/backend code already handles this for things like signup policy and sorting policy. Right now, some of the "metadata" about each queue is in the queues table, but perhaps it should all really be in the queueConfiguration table. It might also be about as much work to change api.php to encode the queue information into data structures and then hook it up to everywhere there are currently database queries as it would be to tweak the configuration.

Setting admins would be easier to implement in the source (basically just change how isAdmin() works. Making a pull request would essentially be a more formal version of "ask James to add them". But, a drawback of this is somebody still needs to approve each pull request, whereas a web interface would be more like "set it and forget it".

For creating new queues, more significant work would be needed to create a web interface, and we would need to figure out how to specify who has permission to create a new queue. Hardcoding these and modifying with PRs might be a good option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants