Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement redis-py's .lock() #79

Closed
akshayjshah opened this issue May 7, 2015 · 7 comments
Closed

Implement redis-py's .lock() #79

akshayjshah opened this issue May 7, 2015 · 7 comments

Comments

@akshayjshah
Copy link

fakeredis.FakeStrictRedis doesn't implement redis-py's .lock() method. Are you open to a pull request that uses the standard lib's threading.Lock to fake the same behavior?

(Of course, I'll follow the contribution guidelines :)

@mansam
Copy link

mansam commented May 12, 2015

Hey there, is there a reason this was closed without comment? I'm actually in need of the same thing.

@akshayjshah
Copy link
Author

I found a workaround for my own use case; if there's some utility in a general solution, though, I'm happy to reopen and open a PR. Just waiting on @jamesls to weigh in.

@akshayjshah akshayjshah reopened this May 12, 2015
@jamesls
Copy link
Owner

jamesls commented Jun 4, 2015

Sorry for the delay. Definitely would be open to a PR that emulates redis-py's lock() method.

@akshayjshah
Copy link
Author

Okay - I definitely won't have time to look at this again for a few weeks, but I can pick it up in early July.

@vitawasalreadytaken
Copy link

This would be very helpful. Have you had time to look at this @akshayjshah?

@akshayjshah
Copy link
Author

As is probably obvious, I don't think I'm going to get to this (probably ever) - I've mostly stopped using Redis and fakredis. Up to @jamesls whether he'd like to close this issue, or whether it's worth keeping around.

@M1ha-Shvn
Copy link

+1 need this

@bmerry bmerry closed this as completed in 030794d Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants