Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing array in cached_asset_file.rb #81

Closed
LeahArmstrong opened this issue Nov 20, 2017 · 4 comments
Closed

Missing array in cached_asset_file.rb #81

LeahArmstrong opened this issue Nov 20, 2017 · 4 comments

Comments

@LeahArmstrong
Copy link
Contributor

Added an array where one appears to be missing.
Causes this error in Rails 4.0.3:

/gems/inline_svg-1.3.0/lib/inline_svg/cached_asset_file.rb:17: syntax error, unexpected ',' (SyntaxError)
    def initialize(paths:, filters: [])

Fix suggested in #80

@jamesmartin
Copy link
Owner

Only visible in Ruby versions older than 2.1, which introduced required keyword arguments. The fix from #80 has been merged. Thanks again, @DustinArmstrong! ✨

@LeahArmstrong
Copy link
Contributor Author

@jamesmartin Would this be a candidate for a 1.3.1 release of the gem?

@jamesmartin
Copy link
Owner

Would this be a candidate for a 1.3.1 release of the gem?

@DustinArmstrong yes, if it's helpful I can make a new release today.

@jamesmartin
Copy link
Owner

v1.3.1 was released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants