Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

Missing iOS phone model detail #30

Closed
RobertoOFonseca opened this issue Jul 30, 2017 · 3 comments
Closed

Missing iOS phone model detail #30

RobertoOFonseca opened this issue Jul 30, 2017 · 3 comments

Comments

@RobertoOFonseca
Copy link

It would be great to have on your plugin detail about iphone model.
CrossDeviceInfo.Current.Model just returns "iPhone"

I've tested method GetVersion() on the link below.
It works fine giving informations such as : iPhone5S,iPod6G, etc...
It just needs to be updated to inform newer models

https://github.com/rangav/iOSDeviceModel/blob/master/DeviceHelper.cs

@jamesmontemagno
Copy link
Owner

This type is unmaintainable as the library would need to be updated with every device release and isn't guaranteed. The model returns the type of device.

@raver99
Copy link

raver99 commented Aug 29, 2018

@jamesmontemagno, I agree with the fact that this needs to be maintainable and creating a mapping between the model name returned by iOS and the marketing model is not maintainable.

But I think it would be more appropriate to return the model given by "hw.machine" property, as did in the link mentioned above.

It would make this plugin more complete and help a lot of it's users.

@jamesmontemagno
Copy link
Owner

This is now part of Xamarin.Essentials and has hw.machine property exposed, which I suggest everyone move to.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants